ZOOKEEPER-2732: Cleanup findbug warnings in branch-3.4: Performance Warnings#231
Closed
afine wants to merge 2 commits intoapache:branch-3.4from
Closed
ZOOKEEPER-2732: Cleanup findbug warnings in branch-3.4: Performance Warnings#231afine wants to merge 2 commits intoapache:branch-3.4from
afine wants to merge 2 commits intoapache:branch-3.4from
Conversation
Contributor
|
+1 LGTM Could you please rebase PR, as this has following conflict with the latest code - ZOOKEEPER-2759. |
Make sure client is connected to a quorum before issuing a write operation to avoid possible race condition between connected to a RO server and forming a new quorum. Author: Michael Han <hanm@apache.org> Reviewers: Rakesh Radhakrishnan <rakeshr@apache.org>, Camille Fournier <camille@apache.org> Closes apache#191 from hanm/ZOOKEEPER-2722 and squashes the following commits: 99bf87f [Michael Han] Make sure syncConnected flag is set to false in read only connected state. 9969979 [Michael Han] ZOOKEEPER-2722: fix flaky test testSessionEstablishment. (cherry picked from commit 2122011) Signed-off-by: Michael Han <hanm@apache.org>
asfgit
pushed a commit
that referenced
this pull request
May 22, 2017
…arnings rakeshadr Apologies for recreating this, I accidentally pushed a bad branch in #231 and GitHub will not let me reset the head for that PR. This should be rebased and ready to be merged. Author: Abraham Fine <afine@apache.org> Reviewers: Rakesh Radhakrishnan <rakeshr@apache.org> Closes #258 from afine/ZOOKEEPER-2732
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.