ZOOKEEPER-2730: Disable i18n warnings until they can be fixed in a sy…#285
Closed
gosubpl wants to merge 1 commit intoapache:branch-3.4from
Closed
ZOOKEEPER-2730: Disable i18n warnings until they can be fixed in a sy…#285gosubpl wants to merge 1 commit intoapache:branch-3.4from
gosubpl wants to merge 1 commit intoapache:branch-3.4from
Conversation
Contributor
|
lgtm. Until there is a solution to fix root problem, I don't see why we should not get this in 3.4 given the same fix has been applied to 3.5 and trunk. |
Contributor
|
Thanks @gosubpl I could see, this was pushed to |
asfgit
pushed a commit
that referenced
this pull request
Jun 19, 2017
…nationalization Warnings …stematic manner Author: gosubpl <github@gosub.pl> Reviewers: Michael Han <hanm@apache.org>, Rakesh Radhakrishnan <rakeshr@apache.org> Closes #285 from gosubpl/ZOOKEEPER-2730
Contributor
|
@gosubpl , I've merged it and please close this PR. |
Author
|
@hanm @rakeshadr many thanks! Closing now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…stematic manner