ZOOKEEPER-2864: Add script to run a java api compatibility tool#329
Closed
afine wants to merge 1 commit intoapache:branch-3.5from
Closed
ZOOKEEPER-2864: Add script to run a java api compatibility tool#329afine wants to merge 1 commit intoapache:branch-3.5from
afine wants to merge 1 commit intoapache:branch-3.5from
Conversation
Contributor
|
I suggest we put this script under zookeeper/src/java/test/bin/ where other scripts are currently located, so it's consistent. A better solution is to consolidate all scripts and put them in a folder with name making more sense, like other projects (e.g. hbase who puts scripts under root/dev-support), but that should be done separately as moving scripts will break a couple of work flows and require coordination. |
Contributor
Author
|
@hanm I moved the script as you suggested. |
hanm
approved these changes
Aug 10, 2017
Contributor
hanm
left a comment
hanm
left a comment
There was a problem hiding this comment.
LGTM.
Document this on cwiki and make it part of release auditing process will be sweet.
asfgit
pushed a commit
that referenced
this pull request
Aug 10, 2017
For example: `python check_compatibility.py branch-3.5..branch-3.4 ` Author: Abraham Fine <afine@apache.org> Reviewers: Michael Han <hanm@apache.org> Closes #329 from afine/ZOOKEEPER-2864
asfgit
pushed a commit
that referenced
this pull request
Aug 10, 2017
For example: `python check_compatibility.py branch-3.5..branch-3.4 ` Author: Abraham Fine <afine@apache.org> Reviewers: Michael Han <hanm@apache.org> Closes #329 from afine/ZOOKEEPER-2864 (cherry picked from commit 82be7f6) Signed-off-by: Michael Han <hanm@apache.org>
Contributor
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
For example: `python check_compatibility.py branch-3.5..branch-3.4 ` Author: Abraham Fine <afine@apache.org> Reviewers: Michael Han <hanm@apache.org> Closes apache#329 from afine/ZOOKEEPER-2864 (cherry picked from commit 82be7f6) Signed-off-by: Michael Han <hanm@apache.org>
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
For example: `python check_compatibility.py branch-3.5..branch-3.4 ` Author: Abraham Fine <afine@apache.org> Reviewers: Michael Han <hanm@apache.org> Closes apache#329 from afine/ZOOKEEPER-2864 (cherry picked from commit 82be7f6) Signed-off-by: Michael Han <hanm@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example:
python check_compatibility.py branch-3.5..branch-3.4