Skip to content

branch-3.4 -- bugfix -- ZOOKEEPER-2890 #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xoiss wants to merge 1 commit into from
Closed

branch-3.4 -- bugfix -- ZOOKEEPER-2890 #359

xoiss wants to merge 1 commit into from

Conversation

@xoiss
Copy link
Contributor

@xoiss xoiss commented Sep 5, 2017

@phunt
Copy link
Contributor

phunt commented Sep 28, 2017

Hi @xoiss please update this PR to follow the guidelines in "generate a pull request" here: https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute - in particular wrt the summary and description text which really helps folks identifying which PRs to prioritize. Thanks!

asfgit pushed a commit that referenced this pull request Oct 10, 2017
@phunt
ZOOKEEPER-2890: Local automatic variable is left uninitialized and th…
948766d 
…en freed.

Fixes https://issues.apache.org/jira/browse/ZOOKEEPER-2890

Author: xoiss <xoiss@ubuntu>

Reviewers: Patrick Hunt <phunt@apache.org>

Closes #359 from xoiss/branch-3.4-bugfix-zookeeper-2890

Change-Id: Ib3d132fc812a62b720967a888aff28edb7f3bdf1
asfgit pushed a commit that referenced this pull request Oct 10, 2017
@phunt
ZOOKEEPER-2890: Local automatic variable is left uninitialized and th…
cc2ab03 
…en freed.

Fixes https://issues.apache.org/jira/browse/ZOOKEEPER-2890

Author: xoiss <xoiss@ubuntu>

Reviewers: Patrick Hunt <phunt@apache.org>

Closes #359 from xoiss/branch-3.4-bugfix-zookeeper-2890

Change-Id: Ib3d132fc812a62b720967a888aff28edb7f3bdf1
(cherry picked from commit 948766d)
Signed-off-by: Patrick Hunt <phunt@apache.org>
@asfgit asfgit closed this in 43a50eb Oct 10, 2017
@phunt
Copy link
Contributor

phunt commented Oct 10, 2017

Thanks @xoiss !

lvfangmin pushed a commit to lvfangmin/zookeeper that referenced this pull request Jun 17, 2018
ZOOKEEPER-2890: Local automatic variable is left uninitialized and th…
6da3338 
…en freed.

Fixes https://issues.apache.org/jira/browse/ZOOKEEPER-2890

Author: xoiss <xoiss@ubuntu>

Reviewers: Patrick Hunt <phunt@apache.org>

Closes apache#359 from xoiss/branch-3.4-bugfix-zookeeper-2890

Change-Id: Ib3d132fc812a62b720967a888aff28edb7f3bdf1
(cherry picked from commit 948766d)
Signed-off-by: Patrick Hunt <phunt@apache.org>
@xoiss
Copy link
Contributor Author

xoiss commented Feb 7, 2019

// xoiss is here

hi, all!
unfortunately i don't have enough time to respond promptly
and moreover i don't check the gmail mail box because of... some reason

ok, what we can do with these?

@anmolnar
Copy link
Contributor

anmolnar commented Feb 7, 2019 •
edited
Loading

@xoiss Glad to see you here again!
You don't need to respond promptly of course, but this PR is 1,5 years old. :)

I reopen it and you can continue working on.

First, please rebase.

@anmolnar anmolnar reopened this Feb 7, 2019
@anmolnar
Copy link
Contributor

anmolnar commented Feb 7, 2019

Hold on a second. This has already been merged.

@anmolnar
Copy link
Contributor

anmolnar commented Feb 7, 2019

Yep. Sorry, my mistake, this one is done.

@anmolnar anmolnar closed this Feb 7, 2019
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@RokLenarcic
ZOOKEEPER-2890: Local automatic variable is left uninitialized and th…
5930c67 
…en freed.

Fixes https://issues.apache.org/jira/browse/ZOOKEEPER-2890

Author: xoiss <xoiss@ubuntu>

Reviewers: Patrick Hunt <phunt@apache.org>

Closes apache#359 from xoiss/branch-3.4-bugfix-zookeeper-2890

Change-Id: Ib3d132fc812a62b720967a888aff28edb7f3bdf1
(cherry picked from commit 948766d)
Signed-off-by: Patrick Hunt <phunt@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xoiss @phunt @anmolnar