ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j#429
Closed
anmolnar wants to merge 2 commits intoapache:masterfrom
Closed
ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j#429anmolnar wants to merge 2 commits intoapache:masterfrom
anmolnar wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
@anmolnar looks like a good change to me - however src/java/lib/ needs to be updated to reflect this change. Also the patch doesn't apply to branch3.4, please submit a separate PR for that. |
Contributor
Author
|
@phunt I've updated the slf4j license. |
anmolnar
force-pushed
the
ZOOKEEPER-2952
branch
from
a309d73 to
89d2f18
Compare
anmolnar
force-pushed
the
ZOOKEEPER-2952
branch
from
89d2f18 to
b488bf4
Compare
asfgit
pushed a commit
that referenced
this pull request
Dec 13, 2017
This is the branch-3.4 version of #429 netty, log4j, slf4j Author: Andor Molnar <andor@cloudera.com> Reviewers: phunt@apache.org Closes #435 from anmolnar/ZOOKEEPER-2952-branch34 Change-Id: Ie75a4be6143d67c9a17c77f945dca4838d8c2430
asfgit
pushed a commit
that referenced
this pull request
Dec 13, 2017
https://issues.apache.org/jira/browse/ZOOKEEPER-2952 Author: Andor Molnar <andor@cloudera.com> Reviewers: phunt@apache.org Closes #429 from anmolnar/ZOOKEEPER-2952 and squashes the following commits: b488bf4 [Andor Molnar] ZOOKEEPER-2952. Updated slf4j license 949ada4 [Andor Molnar] ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j Change-Id: I7cce9cdbefab6c560a582c4dae7b4e00c73b1529 (cherry picked from commit aa8b606) Signed-off-by: Patrick Hunt <phunt@apache.org>
Contributor
|
lgtm +1, thanks @anmolnar |
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
https://issues.apache.org/jira/browse/ZOOKEEPER-2952 Author: Andor Molnar <andor@cloudera.com> Reviewers: phunt@apache.org Closes apache#429 from anmolnar/ZOOKEEPER-2952 and squashes the following commits: b488bf4 [Andor Molnar] ZOOKEEPER-2952. Updated slf4j license 949ada4 [Andor Molnar] ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j Change-Id: I7cce9cdbefab6c560a582c4dae7b4e00c73b1529
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
https://issues.apache.org/jira/browse/ZOOKEEPER-2952 Author: Andor Molnar <andor@cloudera.com> Reviewers: phunt@apache.org Closes apache#429 from anmolnar/ZOOKEEPER-2952 and squashes the following commits: b488bf4 [Andor Molnar] ZOOKEEPER-2952. Updated slf4j license 949ada4 [Andor Molnar] ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j Change-Id: I7cce9cdbefab6c560a582c4dae7b4e00c73b1529
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/ZOOKEEPER-2952