ZOOKEEPER-3001: Incorrect log message when try to delete container node #492
Conversation
| try { | ||
| LOG.info("Attempting to delete candidate container: %s", | ||
| containerPath); | ||
| LOG.info(String.format("Attempting to delete candidate container: %s", |
There was a problem hiding this comment.
As this a log message you could use
LOG.info("Attempting to delete candidate container: {}", container Path);
There was a problem hiding this comment.
to use the same logging style as the other code.
LOG.error(String.format("Could not delete container: %s" ,
containerPath), e);
There was a problem hiding this comment.
+1 for @eribeiro
We already use that form at various places in the codebase, so feel free to use the better one. Existing String.formats should be refactored in the long term, but that probably will happen in small refactorings like this.
| try { | ||
| LOG.info("Attempting to delete candidate container: %s", | ||
| containerPath); | ||
| LOG.info(String.format("Attempting to delete candidate container: %s", |
There was a problem hiding this comment.
+1 for @eribeiro
We already use that form at various places in the codebase, so feel free to use the better one. Existing String.formats should be refactored in the long term, but that probably will happen in small refactorings like this.
|
+1 lgtm |
Missing `String.format`. Author: sel-fish <fqlgy@hotmail.com> Reviewers: Edward Ribeiro <edward.ribeiro@gmail.com>, Andor Molnár <andor@cloudera.com>, Michael Han <hanm@apache.org>, maoling <maoling199210191@sina.com> Closes #492 from sel-fish/ZOOKEEPER-3001 (cherry picked from commit 8cfca3a) Signed-off-by: Michael Han <hanm@apache.org>
Missing `String.format`. Author: sel-fish <fqlgy@hotmail.com> Reviewers: Edward Ribeiro <edward.ribeiro@gmail.com>, Andor Molnár <andor@cloudera.com>, Michael Han <hanm@apache.org>, maoling <maoling199210191@sina.com> Closes apache#492 from sel-fish/ZOOKEEPER-3001
Missing `String.format`. Author: sel-fish <fqlgy@hotmail.com> Reviewers: Edward Ribeiro <edward.ribeiro@gmail.com>, Andor Molnár <andor@cloudera.com>, Michael Han <hanm@apache.org>, maoling <maoling199210191@sina.com> Closes apache#492 from sel-fish/ZOOKEEPER-3001
5 participants
Missing
String.format.