ZOOKEEPER-3022 - MAVEN MIGRATION - Iteration 1 - docs, it #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @nkalmar, looks good to me. |
eolivelli
approved these changes
Jun 27, 2018
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
great.
I really would like to have Maven for ZK.
Let's do it, on step at a time
Contributor
Author
|
You're right @anmolnar , I also realised after seeing the PR that I should have added some text indicating this is part of the migration. I will add it in the future, thanks. |
nkalmar
changed the title
asfgit
pushed a commit
that referenced
this pull request
Jul 4, 2018
First iteration of the directory changes in maven migration. This time, the empty zookeeper-it for future integration tests were created, and the docs source were moved to zookeeper-docs. Tested with forest v0.9, documents generations were successful with ant. Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: Andor Molnar <andor@apache.org> Closes #550 from nkalmar/ZOOKEEPER-3022-1 (cherry picked from commit 4607a3e) Signed-off-by: Andor Molnar <andor@apache.org>
Contributor
|
Committed to master and 3.5 branches. Thanks @nkalmar |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
First iteration of the directory changes in maven migration. This time, the empty zookeeper-it for future integration tests were created, and the docs source were moved to zookeeper-docs. Tested with forest v0.9, documents generations were successful with ant. Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: Andor Molnar <andor@apache.org> Closes apache#550 from nkalmar/ZOOKEEPER-3022-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration of the directory changes in maven migration.
This time, the empty zookeeper-it for future integration tests were created, and the docs source were moved to zookeeper-docs.
Tested with forest v0.9, documents generations were successful with ant.