ZOOKEEPER-3101: add reminder to ZOO_ERRORS

[sl4mmy]

Add comment at bottom of ZOO_ERRORS reminding developers to also
update zerror(int) when adding or changing values. Suggested by
@phunt in #575 (comment).

Signed-off-by: Kent R. Spillner kspillner@acm.org

[sl4mmy]

The Jenkins failure looks like an internal error in Jenkins itself: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1987/consoleText

[sl4mmy]

This commit just adds a comment so I'm not sure how it would cause a build failure other than a style alert, but that doesn't appear to be the case

[nkalmar]

Looks to me jenkins was simply overloaded.
You can re-run the jenkins job by doing an empty --amend commit and pushing it to your PR branch.

[nkalmar]

LGTM, just a useful comment, no code changes.

Yeah, looks like something wrong with the git - https://issues.apache.org/jira/browse/INFRA-16808

[sl4mmy]

@nkalmar Thanks, I just pushed a new commit (slightly reworded the commit message) but the Jenkins build failed again for the same reason: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1990/console

[lvfangmin]

+1 looks like the Jenkins failed due to "NoClassDefFoundError: hudson.model.Computer", is it an environment issue?

[nkalmar]

Yes, all PR fails due to the same reason. I think there is already an INFRA ticket but I'll double check.

[breed]

+1

[anmolnar]

@sl4mmy Would you please trigger another Jenkins build, so that we get a green one and I can commit.

[sl4mmy]

@anmolnar Done, and it passed. Thanks!

[anmolnar]

Quite a simple patch to commit.
@sl4mmy Are u still around? Would you please resolve the conflict?

[sl4mmy]

@anmolnar rebased & pushed. I also added a new commit (fc9ffdb) to handle a new error code that wasn't added to zerror(int) (and fixed the indentation of another case that was added to zerror(int)).

[sl4mmy]

t looks like the Travis build for s390 failed due to:

[FATAL] Non-resolvable parent POM for org.apache.zookeeper:parent:3.7.0-SNAPSHOT: Could not transfer artifact org.apache:apache:pom:23 from/to central (https://repo.maven.apache.org/maven2): /home/travis/.m2/repository/org/apache/apache/23/apache-23.pom.part.lock (No such file or directory) and 'parent.relativePath' points at no local POM @ line 23, column 11
 @ 
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]   
[ERROR]   The project org.apache.zookeeper:parent:3.7.0-SNAPSHOT (/home/travis/build/apache/zookeeper/pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM for org.apache.zookeeper:parent:3.7.0-SNAPSHOT: Could not transfer artifact org.apache:apache:pom:23 from/to central (https://repo.maven.apache.org/maven2): /home/travis/.m2/repository/org/apache/apache/23/apache-23.pom.part.lock (No such file or directory) and 'parent.relativePath' points at no local POM @ line 23, column 11 -> [Help 2]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2] http://cwiki.apache.org/confluence/display/MAVEN/UnresolvableModelException
The command "eval mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V " failed. Retrying, 3 of 3.```

I don't think that was caused by this PR?

[sl4mmy]

Ping @nkalmar @lvfangmin @breed @anmolnar - I rebased this on top of latest master earlier this morning and the build is passing. Would be great to get this merged & closed before it's 2nd birthday (July 23), or before the 2nd anniversary of @nkalmar approving the change (July 24). 😉

[eolivelli]

LGTM

[eolivelli]

committed to master branch ! thank you @sl4mmy