ZOOKEEPER-3177. Revert globalOutstandingLimit refactoring changes #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Nov 21, 2018
| } | ||
|
|
||
| public int getGlobalOutstandingLimit() { | ||
| String sc = System.getProperty(GLOBAL_OUTSTANDING_LIMIT); |
Contributor
There was a problem hiding this comment.
are we reading the system property and parsing the value at every call of shouldThrottle ?
can't we cache the value ?
Contributor
Author
There was a problem hiding this comment.
Yes, that's the case. This is just a dumb revert, please see #712 as another approach for the same issue.
hanm
approved these changes
Nov 21, 2018
Contributor
hanm
left a comment
hanm
left a comment
There was a problem hiding this comment.
LGTM as this effectively resorts to the old approach which has no functional changes.
@eolivelli Does this look good to you? (I saw your code review feedback is 'Request changes' ).
eolivelli
approved these changes
Nov 21, 2018
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Ok let's fix master branch
Contributor
|
Committed to master. Thanks @eolivelli , @anmolnar. |
Contributor
|
Sorry, just saw this, @anmolnar what's the findbugs issue caused by that refactor? |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Hopefully this will fix the findBugs issue on master in the right way. lvfangmin hanm Please validate. Author: Andor Molnar <andor@apache.org> Reviewers: Michael Han <hanm@apache.org>, Enrico Olivelli <eolivelli@gmail.com> Closes apache#711 from anmolnar/ZOOKEEPER-3177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this will fix the findBugs issue on master in the right way.
@lvfangmin @hanm Please validate.