ZOOKEEPER-3281:Add a new CLI:watch #822
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoling
force-pushed
the
ZOOKEEPER-3281
branch
from
d7b37c8 to
10e8bc5
Compare
enixon
reviewed
Mar 13, 2019
| if (e.getType() == Event.EventType.None) { | ||
| return; | ||
| } | ||
| if (e.getState() == Event.KeeperState.SyncConnected) { |
There was a problem hiding this comment.
Does this capture every state that might be encountered? Would it be possible to receive a Disconnected or an AuthFailed event and is there something that might gracefully handle them?
The code for this change looks good to me outside of these questions.
maoling
force-pushed
the
ZOOKEEPER-3281
branch
from
ad47991 to
3466647
Compare
maoling
force-pushed
the
ZOOKEEPER-3281
branch
from
3466647 to
5b06ba3
Compare
|
I like this. Code looks good to me - my only thought for improvement is whether we can move the action on the watch firing into the callback so that this operation can be nonblocking. Anyone else have thoughts? |
maoling
force-pushed
the
ZOOKEEPER-3281
branch
from
49ba876 to
af9bff4
Compare
Member
Author
|
anmolnar
approved these changes
Nov 18, 2019
Contributor
anmolnar
left a comment
anmolnar
left a comment
There was a problem hiding this comment.
+1 lgtm.
Please rebase.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
watchfunction.watchcmd is one-off and it will be blocking until something has changed.ls -w /footo watch the child change,get -w /footo watch the data change,this new cli is also valuable and user-fridendly in a perspective view of watch.-foption: watch a node forever, add-Roption to watch all the events under a dir.watchin thezookeeper.java,the correctness of function has been tested in theWatcherFuncTest,so add no UTs.But a very detailed test evidence has included in the jira