ZOOKEEPER-3314: Document the possibility of MultiCallback receiving a null pointer #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Apr 1, 2019
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
This patch is only about docs. Tests failures are to be ignored.
Thanks
+1 lgtm
maoling
approved these changes
Apr 2, 2019
Contributor
|
Committed to master branch. Thanks @stevenjm ! |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
… null pointer I have tried to get set up to verify that tests pass, but I am still seeing numerous test failures when running `ant test` against the unmodified `master` branch, so I cannot validate that this does not cause failures. Since this particular change is only in documentation, it seems unlikely, so I'm raising a PR anyway. Author: Steven McDonald <steven.mcdonald@usabilla.com> Reviewers: andor@apache.org Closes apache#884 from stevenjm/ZOOKEEPER-3314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to get set up to verify that tests pass, but I am still seeing numerous test failures when running
ant testagainst the unmodifiedmasterbranch, so I cannot validate that this does not cause failures. Since this particular change is only in documentation, it seems unlikely, so I'm raising a PR anyway.