Skip to content

ZOOKEEPER-3344:write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and doc the usage#974

Closed
maoling wants to merge 1 commit intoapache:masterfrom
maoling:ZOOKEEPER-3344
Closed

ZOOKEEPER-3344:write a new script:zkSnapShotToolkit.sh to encapsulate SnapshotFormatter and doc the usage#974
maoling wants to merge 1 commit intoapache:masterfrom
maoling:ZOOKEEPER-3344

Conversation

@maoling
Copy link
Copy Markdown
Member

@maoling maoling commented Jun 8, 2019

  • A test case about zkSnapShotToolkit.cmd in the Windows os was included in the JIRA
  • more details in ZOOKEEPER-3344

@eolivelli
Copy link
Copy Markdown
Contributor

@nkalmar do you have cycles to review ?

Copy link
Copy Markdown
Contributor

@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you @maoling .
I tested the .sh script (no arguments, without data, -d, -json), works as expected.

@maoling
Copy link
Copy Markdown
Member Author

maoling commented Aug 6, 2019

ping @anmolnar

Copy link
Copy Markdown
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in 13b9125 Aug 6, 2019
@anmolnar
Copy link
Copy Markdown
Contributor

anmolnar commented Aug 6, 2019

Merged. Great stuff @maoling !

@maoling maoling deleted the ZOOKEEPER-3344 branch August 7, 2019 01:43
stickyhipp pushed a commit to stickyhipp/zookeeper that referenced this pull request Aug 19, 2020
…e SnapshotFormatter and doc the usage

- A test case about `zkSnapShotToolkit.cmd` in the `Windows` os was included in the [JIRA](https://issues.apache.org/jira/browse/ZOOKEEPER-3344)
- more details in [ZOOKEEPER-3344](https://issues.apache.org/jira/browse/ZOOKEEPER-3344)

Author: maoling <maoling199210191@sina.com>

Reviewers: nkalmar@apache.org, andor@apache.org

Closes apache#974 from maoling/ZOOKEEPER-3344
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
…e SnapshotFormatter and doc the usage

- A test case about `zkSnapShotToolkit.cmd` in the `Windows` os was included in the [JIRA](https://issues.apache.org/jira/browse/ZOOKEEPER-3344)
- more details in [ZOOKEEPER-3344](https://issues.apache.org/jira/browse/ZOOKEEPER-3344)

Author: maoling <maoling199210191@sina.com>

Reviewers: nkalmar@apache.org, andor@apache.org

Closes apache#974 from maoling/ZOOKEEPER-3344
@maoling maoling restored the ZOOKEEPER-3344 branch September 2, 2022 11:52
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
…e SnapshotFormatter and doc the usage

- A test case about `zkSnapShotToolkit.cmd` in the `Windows` os was included in the [JIRA](https://issues.apache.org/jira/browse/ZOOKEEPER-3344)
- more details in [ZOOKEEPER-3344](https://issues.apache.org/jira/browse/ZOOKEEPER-3344)

Author: maoling <maoling199210191@sina.com>

Reviewers: nkalmar@apache.org, andor@apache.org

Closes apache#974 from maoling/ZOOKEEPER-3344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants