Skip to content

fix: report Available condition in version resolution controller#59

Merged
apahim merged 1 commit intoapahim:mainfrom
cristianoveiga:fix/vrc-available-condition
Apr 15, 2026
Merged

fix: report Available condition in version resolution controller#59
apahim merged 1 commit intoapahim:mainfrom
cristianoveiga:fix/vrc-available-condition

Conversation

@cristianoveiga
Copy link
Copy Markdown
Collaborator

Summary

  • The VRC only reported Applied condition after resolving a version, but the CLS backend aggregates Available conditions to compute cluster-level Ready status
  • Without Available, the cluster stays at PartiallyReady (1 of 2 controllers) even when the HostedCluster is fully healthy
  • This caused the e2e pipeline to time out waiting for Ready=True

Changes

  • Add SetAvailableTrue("VersionResolved", ...) on successful version resolution
  • Add SetAvailableFalse("ResolutionFailed", ...) on failed version resolution

Evidence

Backend aggregation (status_aggregator.go:89) only counts controllers with Available: True:

WHERE condition->>'type' = 'Available' AND condition->>'status' = 'True'

Pipeline failure showed cls-hypershift-client reporting Available: True but cls-version-resolution-controller only reporting Applied: True, resulting in "1 of 2 controllers ready".

Test plan

  • go build ./... passes
  • go test ./... passes
  • Deploy to integration and verify cluster reaches Ready: True (2/2 controllers)
  • E2e pipeline passes

🤖 Generated with Claude Code

The VRC only reported Applied condition, but the CLS backend aggregates
Available conditions to compute cluster-level Ready status. Without
Available, the cluster stays at PartiallyReady (1 of 2 controllers)
even when the HostedCluster is fully healthy.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@cristianoveiga cristianoveiga requested a review from apahim April 15, 2026 21:28
Copy link
Copy Markdown
Owner

@apahim apahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@apahim apahim merged commit 5c20318 into apahim:main Apr 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants