Add ChannelIndex and Unit to ChannelView and Group converter #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to only cover realistic values (0 to len(index))
This was referenced Oct 7, 2020
apdavison
pushed a commit
that referenced
this pull request
May 6, 2024
Use pathlib for Intan PR and simplify data type for non header-attached formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a reference conversion of ChannelIndex and Unit objects to View and Group objects.
The conversion allows the automatic update of neo structure based on the deprecated ChannelIndex and Unit objects by replacing them with ChannelView and Group objects.
The conversion preserved information and is done in-place.
Each ChannelIndex is represented as a Group. Linked Unit objects are represented as child Group (subgroup) objects. Linked data objects (neo.AnalogSignal, neo.IrregularlySampledSignal) are represented by a View object linking to the original data object. Attributes are as far as possible conserved by the conversion of objects.
channel_ids,channel_namesandcoordinatesare converted to array_annotations.Furthermore this PR improves the generation of ChannelIndexes for neo unittest purposes and relaxes the dtype of the
Viewx.indexattribute fromnp.integerto any integer type to allow for easy conversion of theChannelIndex.indexattribute.