chore(devx #88): remove license header injection + git pre-commit hook#1701
Merged
Conversation
Per @earayu2 msg=d02d70dd: agents are blocked on every commit by the ``addlicense`` git pre-commit hook (it injects Apache headers and aborts the commit asking the agent to re-commit). The project no longer needs forced license header injection at this stage; this PR removes the friction so agents can commit smoothly. What is removed: - ``scripts/hooks/`` (3 files: ``pre-commit`` + READMEs) -- the pre-commit hook that ran ``make lint`` + ``make add-license`` on every commit. ``make add-license`` modifies files mid-commit and forces a redo, which is the actual blocker. - ``scripts/install-hooks.sh`` -- the helper that copied ``scripts/hooks/*`` into ``.git/hooks/``. - ``Makefile`` targets: ``add-license`` / ``check-license`` / ``install-addlicense`` / ``install-hooks``. The ``addlicense`` binary download path is also gone. - ``env-dev`` no longer depends on ``install-addlicense`` / ``install-hooks``; new clones get a clean dev environment with no license tooling. - ``docs/zh-CN/development/development-guide.md`` lines describing the now-removed hooks + addlicense steps. What is kept (per scope discipline): - ``make lint`` / ``make format`` (ruff check + format) -- still the canonical hygiene gate, runs in CI ``lint-and-unit``. - Existing license headers in source files -- not stripped, since bulk-removing them would be a huge unrelated diff. - Unit / e2e test gates -- untouched. - CI workflows -- never referenced ``add-license`` / ``check-license`` / pre-commit hooks (verified via grep), so no CI changes needed. Local agents that previously had the pre-commit hook installed will still have a stale copy in ``.git/hooks/pre-commit`` until they delete it manually; that is per-clone state, no repo action required. ``make env-dev`` for fresh clones produces no hook. Boundary: hygiene-only PR. No app code, no migration, no schema change. lint + unit gates from main remain in place; only the agent-friction tooling is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per @earayu2 msg=d02d70dd: agents are blocked on every commit by the addlicense git pre-commit hook (it injects Apache headers and aborts the commit asking to re-commit). The project no longer needs forced license header injection at this stage; this PR removes the friction so agents can commit smoothly.
Task #88 (canonical DevX hygiene lane per architect msg=c4c6bd09 / msg=967b3737); #87 closed as duplicate.
What is removed
What is kept (per scope discipline)
Verification
Boundary
Hygiene-only PR. No app code, no migration, no schema change. lint + unit gates from main remain in place; only the agent-friction tooling is removed.
Test plan
🤖 Generated with Claude Code