chore(makefile): remove residual add-license no-op target#1788
Merged
Conversation
The license-check infrastructure (`check-license`, `install-addlicense`, `install-hooks`, the bundled `addlicense` binary, and the git hooks install) was already removed in commit 00ae644 (PR #1729). The `add-license` target left behind only echoes a one-line message and does nothing else, so it is dropped here along with its `.PHONY` entry. License headers in source files are unchanged. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The license-check infrastructure (
check-license,install-addlicense,install-hooks, the bundledaddlicensebinary, the git-hook installer) was already removed in commit00ae644f(PR #1729). The only remaining piece inMakefileis a no-opadd-licensetarget that just echoes a single line and does nothing else. This PR drops that stub along with its.PHONYentry.License headers inside source files are not touched — every
aperag/**.pykeeps its Apache 2.0 header verbatim. TheLICENSEfile at the repo root is also untouched.Why
make add-licenseruns@echo "License headers are maintained in source files."and that is its entire body. Keeping a stub for documentation purposes is dead weight; readers grepadd-licenseand find nothing real..github/workflows/,scripts/, or anywhere else (verified with grep).Test plan
git diff Makefileshows only theadd-licensetarget + its.PHONYlisting removedmake -n add-licensenow reportsNo rule to make target 'add-license'(target gone)make -n formatstill expands to the ruff commands (sibling targets intact)add-license/addlicense/install-addlicense/check-license/install-hooksreferences anywhere in the repo🤖 Generated with Claude Code