fix(mcp): restore default search and chunk reads#1937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- default optional search params before they reach vector/summary/vision ContextManager calls, fixing MCP vector_search calls that omit similarity_threshold\n- make fulltext auto-keyword search include the raw query fallback and use a permissive minimum_should_match for auto-extracted keywords\n- restore read_document_chunk by reading the serving vector row's chunks.jsonl from object storage, including chunk metadata handles\n\n## Tests\n- uv run --extra test python -m pytest tests/unit_test/retrieval/test_mcp_search_defaults.py tests/unit_test/service/test_document_service_chunks.py tests/integration/test_graph_evidence_refs_chain.py -q\n- uv run ruff check aperag/domains/retrieval/pipeline.py aperag/domains/knowledge_base/service/document_service.py tests/unit_test/retrieval/test_mcp_search_defaults.py tests/unit_test/service/test_document_service_chunks.py