refactor: remove max_tokens parameter from LLM configurations and upd…#997
Merged
Conversation
…ate related logic - Removed max_tokens from LLM input and output schemas across multiple YAML files. - Updated LLM service logic to dynamically calculate context length based on model's max_tokens. - Adjusted frontend components to reflect the removal of max_tokens input. - Updated test data to align with the new model configurations.
There was a problem hiding this comment.
Bug: Token Management Logic Ignored
The LLM runner calculates output_max_tokens and passes it to the CompletionService constructor. However, the max_tokens parameter is commented out in all litellm API calls within CompletionService, causing the dynamically calculated token limits to be ignored. This breaks the intended token management logic and can lead to LLM responses exceeding their allocated token budget or causing API errors.
aperag/llm/completion/completion_service.py#L84-L155
ApeRAG/aperag/llm/completion/completion_service.py
Lines 84 to 155 in 9ddce62
aperag/flow/runners/llm.py#L203-L204
ApeRAG/aperag/flow/runners/llm.py
Lines 203 to 204 in 9ddce62
Was this report helpful? Give feedback by reacting with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ate related logic