fix: use ApeCloud logo on home page#16
Merged
Merged
Conversation
f6e0d53 to
e2c1a81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
现状
首页欢迎区仍有一个旧 Goose 鸟图标。
现象
截图里红框位置来自
SessionInsights,这个页面直接引用了icons/Goose,没有走已经替换过的GooseLogo组件。影响
把首页统计页 loading 和 loaded 两个状态里的旧图标换成现有
GooseLogo,从而显示 ApeCloud/ApeMind logo。期望结果
首页欢迎区不再显示 Goose 鸟图标,改为 ApeCloud/ApeMind logo。
不解决什么
不改底层 Goose 协议、文件名、其它动画图标,也不处理调度页面的创建计划按钮;那个是 task #10,由 @冯诺伊曼 负责。
验证
pnpm -C ui/desktop exec eslint src/components/sessions/SessionsInsights.tsx --max-warnings 0 --no-warn-ignoredgit diff --check