Skip to content

fix: Raise the version constraint of KBCLI and KB (#300)#339

Merged
d976045024 merged 3 commits intomainfrom
support/check-version-constraint
May 8, 2024
Merged

fix: Raise the version constraint of KBCLI and KB (#300)#339
d976045024 merged 3 commits intomainfrom
support/check-version-constraint

Conversation

@d976045024
Copy link
Copy Markdown
Contributor

fix #300

@d976045024 d976045024 requested a review from shanshanying May 8, 2024 09:05
@github-actions github-actions Bot added the size/S Denotes a PR that changes 10-29 lines. label May 8, 2024
Comment thread pkg/cmd/version/version.go Outdated
@d976045024 d976045024 requested a review from ldming May 8, 2024 09:22
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 8, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 42.81%. Comparing base (1fe3124) to head (b8a5ea6).
Report is 4 commits behind head on main.

Files Patch % Lines
pkg/cmd/version/version.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   42.80%   42.81%           
=======================================
  Files         213      213           
  Lines       29109    29111    +2     
=======================================
+ Hits        12461    12463    +2     
  Misses      15107    15107           
  Partials     1541     1541           
Flag Coverage Δ
unittests 42.81% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d976045024 d976045024 merged commit 756c7e2 into main May 8, 2024
@d976045024 d976045024 deleted the support/check-version-constraint branch May 8, 2024 13:07
@github-actions github-actions Bot added this to the Release 0.9.0 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Raise the version constraint of KBCLI and KB, only MINOR version matters

3 participants