Skip to content

fix: support create sharding cluster#435

Merged
yipeng1030 merged 3 commits intomainfrom
bugfix/fix_create_shard_cluster
Sep 2, 2024
Merged

fix: support create sharding cluster#435
yipeng1030 merged 3 commits intomainfrom
bugfix/fix_create_shard_cluster

Conversation

@yipeng1030
Copy link
Copy Markdown
Contributor

@yipeng1030 yipeng1030 commented Aug 29, 2024

fix #428

Change

  • Support verifying componnetDef from shardingSpecs of Cluster.

Test

  • After fixed, a redis cluster of mode "cluster" can be created correctly.
  1. Edit go build configuration.
image
  1. Run kbcli with create commands and get result.
image
  1. Check the phase of redis cluster.
image

@github-actions github-actions Bot added the size/S Denotes a PR that changes 10-29 lines. label Aug 29, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.89%. Comparing base (0657641) to head (7a668e9).

Files with missing lines Patch % Lines
pkg/cmd/cluster/create_subcmds.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   44.89%   44.89%           
=======================================
  Files         157      157           
  Lines       23000    23007    +7     
=======================================
+ Hits        10325    10330    +5     
- Misses      11443    11445    +2     
  Partials     1232     1232           
Flag Coverage Δ
unittests 44.89% <90.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions Bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Sep 2, 2024
@yipeng1030 yipeng1030 merged commit 4874b3a into main Sep 2, 2024
@yipeng1030 yipeng1030 deleted the bugfix/fix_create_shard_cluster branch September 2, 2024 10:51
@github-actions github-actions Bot added this to the Release 0.9.1 milestone Sep 2, 2024
@yipeng1030
Copy link
Copy Markdown
Contributor Author

/cherry-pick release-0.9

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 2, 2024

🤖 says: Error cherry-picking.

Auto-merging pkg/cmd/cluster/create_subcmds.go
Auto-merging pkg/cmd/cluster/create_subcmds_test.go
CONFLICT (content): Merge conflict in pkg/cmd/cluster/create_subcmds_test.go
error: could not apply 4874b3a... fix: support create sharding cluster (#435)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 2, 2024

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kbcli/actions/runs/10665761524

yipeng1030 added a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] failed to create redis cluster

3 participants