fix: fetch kb version from helm release chart before upgrade#466
Merged
yipeng1030 merged 2 commits intomainfrom Oct 14, 2024
Merged
fix: fetch kb version from helm release chart before upgrade#466yipeng1030 merged 2 commits intomainfrom
yipeng1030 merged 2 commits intomainfrom
Conversation
yipeng1030
requested review from
1aal,
free6om,
heng4fun,
ldming,
leon-inf,
nayutah and
wangyelei
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
+ Coverage 41.58% 41.59% +0.01%
==========================================
Files 165 165
Lines 22883 22893 +10
==========================================
+ Hits 9515 9522 +7
- Misses 12253 12255 +2
- Partials 1115 1116 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ldming
approved these changes
Oct 14, 2024
yipeng1030
deleted the
bugfix/fix_method_of_fetch_version_when_upgrade
branch
Contributor
Author
|
/cherry-pick release-0.9 |
|
🤖 says: cherry pick action finished successfully 🎉! |
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
(cherry picked from commit b291757)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #452
What's changed?
get the KB version from the helm release, instead of from KB deployment.