Skip to content

chore: playground only support k3d and aws#472

Merged
yipeng1030 merged 8 commits intomainfrom
revert-471-feature/playground_only_support_k3d
Oct 24, 2024
Merged

chore: playground only support k3d and aws#472
yipeng1030 merged 8 commits intomainfrom
revert-471-feature/playground_only_support_k3d

Conversation

@yipeng1030
Copy link
Copy Markdown
Contributor

@yipeng1030 yipeng1030 commented Oct 21, 2024

Reverts #471

  1. playground support aws cloud besides k3d locally.
  2. fix 'make kbcli'

@github-actions github-actions Bot added the size/L Denotes a PR that changes 100-499 lines. label Oct 21, 2024
@yipeng1030 yipeng1030 marked this pull request as draft October 21, 2024 04:04
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 17.85714% with 138 lines in your changes missing coverage. Please review.

Project coverage is 42.00%. Comparing base (38fecd8) to head (b513953).

Files with missing lines Patch % Lines
pkg/cmd/playground/init.go 25.92% 76 Missing and 4 partials ⚠️
pkg/cmd/playground/destroy.go 0.00% 56 Missing ⚠️
pkg/cloudprovider/types.go 0.00% 1 Missing ⚠️
pkg/cluster/helper.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
- Coverage   42.22%   42.00%   -0.23%     
==========================================
  Files         167      167              
  Lines       22837    22979     +142     
==========================================
+ Hits         9644     9653       +9     
- Misses      12082    12212     +130     
- Partials     1111     1114       +3     
Flag Coverage Δ
unittests 42.00% <17.85%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yipeng1030 yipeng1030 changed the title Revert "feat: playground only support k3d" feat: playground only support k3d and aws Oct 21, 2024
@yipeng1030 yipeng1030 changed the title feat: playground only support k3d and aws chore: playground only support k3d and aws Oct 21, 2024
@yipeng1030 yipeng1030 marked this pull request as ready for review October 23, 2024 03:31
@yipeng1030 yipeng1030 force-pushed the revert-471-feature/playground_only_support_k3d branch from 82e62e8 to 080c3a1 Compare October 23, 2024 03:37
@ldming
Copy link
Copy Markdown
Collaborator

ldming commented Oct 24, 2024

Fix the conflict.

@yipeng1030 yipeng1030 merged commit 0be0409 into main Oct 24, 2024
@yipeng1030 yipeng1030 deleted the revert-471-feature/playground_only_support_k3d branch October 24, 2024 03:57
@github-actions github-actions Bot added this to the Release 1.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants