Skip to content

chore: adapt clusterDefinition commands#476

Merged
wangyelei merged 10 commits intomainfrom
feature/adapt_cluster_definition
Oct 23, 2024
Merged

chore: adapt clusterDefinition commands#476
wangyelei merged 10 commits intomainfrom
feature/adapt_cluster_definition

Conversation

@wangyelei
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the size/XL Denotes a PR that changes 500-999 lines. label Oct 23, 2024
@wangyelei wangyelei force-pushed the feature/adapt_cluster_definition branch from ce07769 to 32c8e8e Compare October 23, 2024 08:33
@wangyelei
Copy link
Copy Markdown
Contributor Author

/approved

@wangyelei
Copy link
Copy Markdown
Contributor Author

/approved

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 23, 2024

Codecov Report

❌ Patch coverage is 11.90476% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.22%. Comparing base (7eb7567) to head (37d4cdc).
⚠️ Report is 101 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/clusterdefinition/describe.go 0.00% 64 Missing ⚠️
pkg/cluster/helper.go 0.00% 6 Missing ⚠️
pkg/cluster/cluster.go 0.00% 1 Missing and 1 partial ⚠️
pkg/types/types.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   42.28%   42.22%   -0.07%     
==========================================
  Files         169      167       -2     
  Lines       22880    22837      -43     
==========================================
- Hits         9675     9642      -33     
+ Misses      12092    12084       -8     
+ Partials     1113     1111       -2     
Flag Coverage Δ
unittests 42.22% <11.90%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangyelei wangyelei merged commit 38fecd8 into main Oct 23, 2024
@wangyelei wangyelei deleted the feature/adapt_cluster_definition branch October 23, 2024 11:33
@github-actions github-actions Bot added this to the Release 1.0 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Denotes a PR that changes 500-999 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants