Skip to content

chore: fix check upgrade release status#492

Merged
yipeng1030 merged 2 commits intomainfrom
bugfix/fix_upgrade
Nov 21, 2024
Merged

chore: fix check upgrade release status#492
yipeng1030 merged 2 commits intomainfrom
bugfix/fix_upgrade

Conversation

@yipeng1030
Copy link
Contributor

@yipeng1030 yipeng1030 commented Nov 20, 2024

move checking upgrade release status from kubeblocks/upgrade() to helm/upgrade() and improve UT.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Nov 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 42.65%. Comparing base (9584c24) to head (f791f0c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/helm/helm.go 71.42% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   42.66%   42.65%   -0.02%     
==========================================
  Files         172      172              
  Lines       23276    23285       +9     
==========================================
+ Hits         9931     9932       +1     
- Misses      12210    12216       +6     
- Partials     1135     1137       +2     
Flag Coverage Δ
unittests 42.65% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yipeng1030 yipeng1030 merged commit 11e98be into main Nov 21, 2024
@yipeng1030 yipeng1030 deleted the bugfix/fix_upgrade branch November 21, 2024 03:51
@github-actions github-actions bot added this to the Release 1.0 milestone Nov 21, 2024
@yipeng1030
Copy link
Contributor Author

/cherry-pick release-1.0

@github-actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/11946298958

github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants