chore: playground init support specifying k3s and k3d-proxy images.#500
Merged
yipeng1030 merged 3 commits intomainfrom Nov 29, 2024
Merged
chore: playground init support specifying k3s and k3d-proxy images.#500yipeng1030 merged 3 commits intomainfrom
yipeng1030 merged 3 commits intomainfrom
Conversation
1918124 to
4621556
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 42.59% 42.58% -0.01%
==========================================
Files 172 172
Lines 23328 23337 +9
==========================================
+ Hits 9937 9939 +2
- Misses 12255 12261 +6
- Partials 1136 1137 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
shanshanying
left a comment
There was a problem hiding this comment.
Better to encode infos (k3sImage string, k3dProxyImage string) into a struct.
wangyelei
approved these changes
Nov 29, 2024
Contributor
Author
|
/cherry-pick release-1.0 |
|
🤖 says: cherry pick action finished successfully 🎉! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #488
playground initsupport specifying k3s and k3d-proxy images by two flags--k3s-imageand--k3d-proxy-image.kbcli playground init --k3d-proxy-image=registry.aliyuncs.com/apecloud/k3d-proxy:5.4.4to specify the image of k3d-proxy.