Skip to content

chore: addon install and search support auto complete#518

Merged
yipeng1030 merged 4 commits intomainfrom
feature/addon_search_regex_match
Dec 16, 2024
Merged

chore: addon install and search support auto complete#518
yipeng1030 merged 4 commits intomainfrom
feature/addon_search_regex_match

Conversation

@yipeng1030
Copy link
Contributor

@yipeng1030 yipeng1030 commented Dec 13, 2024

fix #517

kbcli addon install and kbcli addon search support auto complete the name of addon. All names of addon are read from the index diractory.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Dec 13, 2024
@yipeng1030 yipeng1030 force-pushed the feature/addon_search_regex_match branch from 7e6f5c4 to 5e32c5b Compare December 13, 2024 07:46
@yipeng1030 yipeng1030 changed the title chore: addon install and search support validComplete chore: addon install and search support auto complete Dec 13, 2024
@yipeng1030 yipeng1030 marked this pull request as ready for review December 13, 2024 08:06
@yipeng1030 yipeng1030 force-pushed the feature/addon_search_regex_match branch from 8ce9b3e to 74188b8 Compare December 13, 2024 08:10
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 38.33333% with 74 lines in your changes missing coverage. Please review.

Project coverage is 41.14%. Comparing base (96adf78) to head (b8ab309).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/addon/util.go 1.56% 63 Missing ⚠️
pkg/cmd/addon/search.go 80.35% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   41.22%   41.14%   -0.08%     
==========================================
  Files         185      185              
  Lines       24398    24473      +75     
==========================================
+ Hits        10058    10070      +12     
- Misses      13189    13253      +64     
+ Partials     1151     1150       -1     
Flag Coverage Δ
unittests 41.14% <38.33%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei
Copy link
Contributor

/approved

@yipeng1030 yipeng1030 merged commit 34f8339 into main Dec 16, 2024
@yipeng1030 yipeng1030 deleted the feature/addon_search_regex_match branch December 16, 2024 07:03
@github-actions github-actions bot added this to the Release 1.0 milestone Dec 16, 2024
@yipeng1030
Copy link
Contributor Author

/cherry-pick release-1.0

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/12347576956

apecloud-bot pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] kbcli addon search support regex match

4 participants