docs: add postReady bounded timeout + failure classification guide#122
Open
weicao wants to merge 1 commit into
Open
docs: add postReady bounded timeout + failure classification guide#122weicao wants to merge 1 commit into
weicao wants to merge 1 commit into
Conversation
Methodology body covers: - Why long postReady operations need bounded timeout vs. let-it-run - 5 hard rules: outer timeout per client call, bounded retry not while-true, 5-layer failure classification (env / runner / control-plane / engine / converge-timeout) with distinct exit codes 70-74, trap EXIT INT TERM cleanup, caller budget > internal step bounded > per-step timeout layering - patch-gate 4 indicators (postReady_has_outer_timeout / postReady_no_while_true_unbounded / postReady_failure_reason_strings / postReady_trap_cleanup) only prove fix in place, NOT product / acceptance / release-ready - 6-point PR review checklist - 3 anti-pattern vs correct pattern pairs Appendix A is OceanBase enterprise addon oceanbase-physical-backup postReady CREATE STANDBY TENANT case (live sha b74912857084451adbf707166a82bd8f55efce5ca74f3b2ce964c65451fc9925) with explicit "do not extrapolate" boundary; 6-sample observation across two runtime paths supports only that no hang re-occurred in those samples, not that hang can never re-occur.
Contributor
Author
|
Blocking for merge:
Direction looks useful; keep the appendix boundary narrow. After these are fixed I can re-run repo-level checks. |
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New methodology doc
addon-postready-bounded-timeout-failure-classification-guide.mdcovering when addon DataProtectionActionSet.spec.restore.postReadyissues a long-running engine command (e.g.CREATE STANDBY TENANT, secondary rebuild, second-stage restore), how to bound it and classify failures.Body (generic methodology, version-agnostic, no engine binding):
timeout -k 1 Nper client call; bounded retry (nowhile true); 5-layer failure classification (env / runner / control-plane / engine-error / engine-converge-timeout) with distinct exit codes 70–74 and reason strings; trapEXIT INT TERMcleanup; budget layering (caller > internal step bounded > per-step timeout)postReady_has_outer_timeout,postReady_no_while_true_unbounded,postReady_failure_reason_strings,postReady_trap_cleanup) — only prove fix in live ActionSet, NOT product / functional / acceptance / release-readyexit 1)addon-mysql-credential-hygiene-no-argv-guide.md,addon-bounded-eventual-convergence-guide.md,addon-test-acceptance-and-first-blocker-guide.md,addon-evidence-discipline-guide.mdAppendix A is OceanBase enterprise addon
oceanbase-physical-backuppostReadyCREATE STANDBY TENANTcase (live shab74912857084451adbf707166a82bd8f55efce5ca74f3b2ce964c65451fc9925) with explicit boundary statement. 6-sample observation across two runtime paths supports only that no hang re-occurred in those samples, NOT extrapolated to PITR full coverage / addon acceptance / release-ready / hang permanently eliminated.SKILL-INDEX.md updated: added entry under
### 1. 设计 / 开发新 addonwith single-line concise description.Test plan
mysql/obclientas generic MySQL-protocol client refs)🤖 Generated with Claude Code