Conversation
nashtsai
reviewed
Feb 22, 2023
internal/controller/dag/dag.go
Outdated
|
|
||
| package dag | ||
|
|
||
| type DAG struct { |
Contributor
There was a problem hiding this comment.
check controller-idioms handlers: https://github.com/authzed/controller-idioms#handlers
and usages in this branch:
https://github.com/apecloud/kubeblocks/blob/feature/addon/controllers/extensions/addonspec_controller.go#L108
Contributor
|
We don't need a DAG framework, I've introduced stateless for operator developers - https://pkg.go.dev/github.com/qmuntal/stateless#section-readme. Use HSM for complex states handling, but for KubeBlocks Cluster operation controller-idioms's handler with both parallel and chain and chain with decision is sufficient enough. |
This reverts commit 731a1ae.
…component.phase=stopped to updating, statefulset controller may set component.phase to failed, causing start-ops to fail
nayutah
approved these changes
Mar 29, 2023
leon-inf
approved these changes
Mar 29, 2023
free6om
added a commit
that referenced
this pull request
Apr 23, 2023
an enhancement to PR #1571 with following improvements: 1. add `AddTransformers`/`AddParallelTransformers` interface and move plan `Build` stage back to cluster controller 2. handle deletion first to support fast&force deletion 3. emit events after cluster status updated (in the `Execute` stage) 4. sample ut in `transformer_sts_horizontal_scaling_test.go` to show how to test a transformer without `envtest` 5. more docs and other minor improvements
free6om
added a commit
that referenced
this pull request
Apr 23, 2023
an enhancement to PR #1571 with following improvements: 1. add `AddTransformers`/`AddParallelTransformers` interface and move plan `Build` stage back to cluster controller 2. handle deletion first to support fast&force deletion 3. emit events after cluster status updated (in the `Execute` stage) 4. sample ut in `transformer_sts_horizontal_scaling_test.go` to show how to test a transformer without `envtest` 5. more docs and other minor improvements (cherry picked from commit 70828b6)
nashtsai
pushed a commit
that referenced
this pull request
Apr 23, 2023
an enhancement to PR #1571 with following improvements: 1. add `AddTransformers`/`AddParallelTransformers` interface and move plan `Build` stage back to cluster controller 2. handle deletion first to support fast&force deletion 3. emit events after cluster status updated (in the `Execute` stage) 4. sample ut in `transformer_sts_horizontal_scaling_test.go` to show how to test a transformer without `envtest` 5. more docs and other minor improvements (cherry picked from commit 70828b6)
nashtsai
pushed a commit
that referenced
this pull request
Apr 23, 2023
an enhancement to PR #1571 with following improvements: 1. add `AddTransformers`/`AddParallelTransformers` interface and move plan `Build` stage back to cluster controller 2. handle deletion first to support fast&force deletion 3. emit events after cluster status updated (in the `Execute` stage) 4. sample ut in `transformer_sts_horizontal_scaling_test.go` to show how to test a transformer without `envtest` 5. more docs and other minor improvements (cherry picked from commit 70828b6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor lifecycle in a more structured way