Skip to content

fix: github action uploads kbcli asset for windows and add powershell script to install on windows#2449

Merged
ldming merged 4 commits intomainfrom
support/windows-sup-unify
Apr 10, 2023
Merged

fix: github action uploads kbcli asset for windows and add powershell script to install on windows#2449
ldming merged 4 commits intomainfrom
support/windows-sup-unify

Conversation

@1aal
Copy link
Copy Markdown
Contributor

@1aal 1aal commented Apr 7, 2023

For these problems of kbcli in windos OS:

  1. missing binary suffixes .exe.
  2. the tar tool is not available.
  3. zip too deep and he compressed folder's name containing . causes error.
  4. do not change the install_cli.sh for linux and mac to ensure installation support for older versions.

Only modified .github/workflows/release-publish.yaml .

@1aal 1aal marked this pull request as ready for review April 7, 2023 08:50
@1aal 1aal changed the title Support/windows sup unify Support/windows sup unify Fixes #2423 Apr 7, 2023
@1aal 1aal changed the title Support/windows sup unify Fixes #2423 Support/windows sup unify Fixes Apr 7, 2023
@ldming ldming changed the title Support/windows sup unify Fixes fix: github action uploads kbcli asset for windows and add powershell script to install on windows Apr 7, 2023
@ldming ldming added area/cli Something about CLI area/user-interaction labels Apr 7, 2023
@ldming ldming added this to the Release 0.5.0 milestone Apr 7, 2023
@ldming ldming merged commit 8f6f937 into main Apr 10, 2023
@ldming ldming deleted the support/windows-sup-unify branch April 10, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] github action upload wrong kbcli asset for windows [Function]Support kbcli in windows

5 participants