fix: mysql cluster execute ops VolumeExpansion Failed#2950
Merged
Conversation
free6om
requested review from
dengshaojiang,
heng4fun,
ldming,
leon-inf,
nashtsai,
nayutah and
wangyelei
as code owners
nashtsai
reviewed
Apr 25, 2023
| createPVC(clusterObject.Name, storageClassName, vctName, pvcName) | ||
| pvcNames := make([]string, 0) | ||
| for i := 0; i < replicas; i++ { | ||
| pvcName := fmt.Sprintf("%s-%s-%s-%d", vctName, clusterObject.Name, consensusCompName, i) |
Contributor
There was a problem hiding this comment.
seems duplicated to other test cases, would be better this is provided by cluster.spec.componentSpecs.GetVolumeClaimTemplatePrefix helper function
nashtsai
approved these changes
Apr 25, 2023
wangyelei
approved these changes
Apr 25, 2023
nashtsai
approved these changes
Apr 25, 2023
free6om
deleted the
bugfix/mysql-cluster-execute-ops-VolumeExpansion-failed
branch
free6om
added a commit
that referenced
this pull request
Apr 25, 2023
(cherry picked from commit 87ae373)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2891