Merged
Conversation
Factor out duplicated code between STOMP and AMS receiving/pulling methods for saving the messages to disk (by adding them to a dirq queue). Additionally this change ensures that messages, once pulled from AMS are always acknowledged, whether they are written out successfully, which mirrors the behavious of the STOMP method.
Set imports from argo_ams_libaray to None if the package isn't available and raise an import error if AMS is then used.
- Make argo-ams-library optional in install files so SSM can be installed without it. - Tweak extras_require to use "feature" names for the keys.
gregcorbett
reviewed
Feb 10, 2020
| extras_require={ | ||
| 'python-daemon': ['python-daemon'], | ||
| 'AMS': ['argo-ams-library'], | ||
| 'daemon': ['python-daemon'], |
Member
There was a problem hiding this comment.
Changing things?! I guess as this is milestone'd for 3.0.0 we can go crazy :p!
Member
Author
There was a problem hiding this comment.
The dictionary key is meant to be the name of the optional "feature" of your software rather than just the name of the package.
gregcorbett
approved these changes
Feb 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #95 by addressing most of the items in the issue.
argo-ams-libraryhas been made optional._save_msg_to_queue._send_msg_ams.It doesn't pull out AMS and STOMP functions to their own files, but that's a larger thing that is probably dependant on
stomp.pybeing made optional (but it has a lot of low level integration in the code). Follow up issue in #120.