feature(CORS): Remove CORS proxy for R2 parquet downloads in Pyodide#22
Merged
feature(CORS): Remove CORS proxy for R2 parquet downloads in Pyodide#22
Conversation
R2 buckets now have CORS configured to allow GET from the browser, so presigned URLs can be fetched directly. This removes the extra server hop that was streaming all parquet bytes through the app server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the CORS proxy layer for parquet file downloads in Pyodide/WASM environments. Parquet files are now downloaded directly from presigned R2 URLs, which have CORS headers configured on the R2 buckets to allow cross-origin GET requests from the browser.
Key Changes
{base_url}/data/proxypyfetch(url, method="GET")_to_js_headers()conversion since presigned URLs carry authentication in query parameters (X-Amz-*) and don't require additional headersImplementation Details
https://claude.ai/code/session_011sUKbmutP1bnrtk6yJgUUX