Release 0.4.0#22
Conversation
Add `a11y` boolean input to reusable-wp-e2e.yml that installs @axe-core/playwright when enabled.
Playwright-based visual regression testing for WordPress using wp-env. Supports screenshot comparison with configurable thresholds, viewports, and color schemes. Closes #18
Add workflow documentation to README, CLAUDE.md inventory table, and CHANGELOG entry for v0.4.0.
feat(e2e): add optional a11y testing support
feat: add visual regression testing workflow
feat: add Lighthouse CI workflow
|
/gemini review |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This release introduces several new testing capabilities to the reusable workflow suite, specifically targeting accessibility, performance auditing, and visual regression testing. These additions are designed to be non-breaking and provide greater flexibility for automated quality assurance in WordPress projects. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Tests run fast and screens are checked, / No visual bugs shall we neglect. / With Lighthouse scores and axe in tow, / Our code quality starts to grow. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two new reusable workflows: reusable-lhci.yml for Lighthouse CI audits and reusable-wp-visual-regression.yml for visual regression testing. The documentation in README.md, CHANGELOG.md, and CLAUDE.md has been updated to reflect these additions. Feedback was provided to improve the consistency and clarity of the documentation, specifically regarding the use of backticks for technical terms, filenames, and configuration options, as well as ensuring consistency in input descriptions.
Use env vars instead of direct input interpolation in shell commands. Add npm cache and consistent error message.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces two new reusable workflows: reusable-lhci.yml for Lighthouse CI audits and reusable-wp-visual-regression.yml for visual regression testing, along with the necessary documentation updates. I have provided feedback to improve the documentation clarity regarding environment setup, ensure consistency in versioning descriptions, and correct the input type for the visual regression threshold to match project standards.
There was a problem hiding this comment.
Pull request overview
Release 0.4.0 adds three reusable CI capabilities to this repo’s GitHub Actions workflow suite: optional Playwright a11y dependency installation for WP E2E runs, a Lighthouse CI audit workflow, and a Playwright-based visual regression workflow.
Changes:
- Added
a11yinput toreusable-wp-e2e.ymlto optionally install@axe-core/playwright. - Added
reusable-lhci.ymlto run Lighthouse CI audits with configurable score thresholds (and optional wp-env setup). - Added
reusable-wp-visual-regression.ymlto run Playwright screenshot regression testing, with artifacts for diffs/reports and optional snapshot updates.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents new workflow inputs/usages for LHCI and visual regression; adds a11y input to WP E2E docs. |
| CLAUDE.md | Updates the workflow inventory list to include the two new reusable workflows. |
| CHANGELOG.md | Adds 0.4.0 release notes covering the three new features. |
| .github/workflows/reusable-wp-e2e.yml | Adds optional conditional install step for @axe-core/playwright via a11y input. |
| .github/workflows/reusable-lhci.yml | Introduces Lighthouse CI reusable workflow with threshold-driven config generation and artifact upload. |
| .github/workflows/reusable-wp-visual-regression.yml | Introduces Playwright-based visual regression workflow with wp-env setup and artifact strategy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request introduces three new reusable workflows: reusable-wp-e2e.yml with optional accessibility testing via @axe-core/playwright, reusable-lhci.yml for Lighthouse CI audits, and reusable-wp-visual-regression.yml for Playwright-based visual regression testing. The documentation in README.md, CLAUDE.md, and CHANGELOG.md has been updated to include these new tools. Feedback was provided to pin the workflow references in the README examples to a major version tag (e.g., @v0) instead of @main to ensure stability and prevent unexpected breakages for consumers.
- chromeFlags must be array, not string (lhci) - add *-snapshots/ to upload paths (vrt) - README formatting and consistency fixes
Check if v<VERSION> git tag exists and fail if so. Prevents PRs from merging without bumping CHANGELOG when the top version already has a release tag. Closes #13
Branch protection rules reference checks by job ID (workflow / job-id), but GitHub reports the display name when set, causing checks to stay stuck at "Waiting for status to be reported". Closes #12
Matrix-based workflows now have a static-named summary job that consumers can target in branch protection rules. The matrix job names evaluate cleanly when skipped. Closes #11
|
/gemini review |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request introduces version 0.4.0, adding new reusable workflows for Lighthouse CI audits and Playwright-based visual regression testing. It also includes an optional accessibility check for E2E tests, documents the actionlint integration, and provides guidance on using summary jobs for branch protection. Feedback was provided to update the documentation for the visual regression threshold to use a number type instead of a string for consistency with other workflows.
Prevents artifact name collisions when the workflow is invoked multiple times in a run (e.g. via matrix or parallel jobs).
Summary
@axe-core/playwrightsupport toreusable-wp-e2e.ymlviaa11yinput (Support @axe-core/playwright in e2e workflow #16)reusable-lhci.ymlworkflow for Lighthouse CI audits with configurable score thresholds (Add reusable Lighthouse CI workflow #17)reusable-wp-visual-regression.ymlworkflow for Playwright-based visual regression testing (Add visual regression testing workflow #18)All changes are non-breaking, additive features.
Test plan
reusable-wp-e2e.yml—a11yinput and conditional@axe-core/playwrightinstall stepreusable-lhci.yml— input defaults,jqconfig generation, wp-env setup, artifact uploadreusable-wp-visual-regression.yml— matrix prep, wp-env setup, VRT env vars, artifact strategy