fix(commits): skip default git revert messages#34
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the developer experience by adjusting how conventional commit messages are validated. By allowing default git revert messages to bypass the strict conventional commit check, it ensures that automated tools relying on the standard 'Revert' prefix continue to function correctly while maintaining validation for manually authored revert commits. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. The revert message caused a fight, / The validator wasn't right. / We skipped the text, / To keep things flexed, / And now the commits are looking bright. Footnotes
|
|
Released as v0.6.2 |
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG.md to document a fix for skipping default git revert messages in the conventional commit validator. However, the actual implementation of this fix in reusable-conventional-commits.yml is missing from the current changes.
| - `reusable-conventional-commits.yml` — skip the default message that `git revert` generates | ||
| (`Revert "<original subject>"`) the same way merge commits are skipped. Previously the | ||
| validator rejected reverts and forced contributors to hand-edit the message into the | ||
| conventional schema, which dropped the `Revert "` prefix that release-please and similar | ||
| tools rely on to group reverts. Hand-written `revert: …` / `revert(scope): …` subjects are | ||
| still validated against `allowed-types`. (#33) |
There was a problem hiding this comment.
The implementation of the fix described in this CHANGELOG entry and the pull request description (extending the merge-commit skip in reusable-conventional-commits.yml) appears to be missing from the current changes. Only CHANGELOG.md has been modified. Please ensure the corresponding logic changes are included in the pull request.
Summary
reusable-conventional-commits.ymlto also bypass the default message thatgit revertgenerates (Revert "<original subject>").revert: …/revert(scope): …subjects still go throughallowed-typesvalidation — only the auto-generated form is bypassed.Fixes #33.
Test plan
Revert "feat(foo): add bar"style subject would now be skipped by the bash matcher