fix(loader): show throughput even when errors occur#670
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes loader/parallel execution stats output so “Overall insertion throughput” is reported as a numeric value even when errors occurred (instead of the literal NaN string), addressing issue #244 where throughput was hidden whenever error_counter > 0.
Changes:
- Always print the computed overall throughput value in
print_stats()forParallelLoader,ParallelQuery, andParallelQuerySet(no longer conditional onerror_counter == 0). - Update the stats test expectation to validate a numeric throughput output when errors occur.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
aperturedb/ParallelQuerySet.py |
Removes the error_counter-based conditional that forced throughput to print as NaN. |
aperturedb/ParallelQuery.py |
Removes the error_counter-based conditional that forced throughput to print as NaN. |
aperturedb/ParallelLoader.py |
Removes the error_counter-based conditional that forced throughput to print as NaN. |
test/test_Stats.py |
Updates the assertion for overall throughput output when errors occur. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
579a023 to
c82424e
Compare
Addresses review feedback from Copilot regarding throughput calculation
Contributor
Author
|
Addressed feedback from @Copilot:
Updated in commit aa5c638 |
luisremis
approved these changes
May 19, 2026
luisremis
previously approved these changes
May 19, 2026
Contributor
Author
|
I noticed the CI failure related to succeeded_queries in dry_run mode (which caused test_varying_commands_blobs to fail). I pushed a fix for that to correctly populate actual_stats. |
luisremis
previously approved these changes
May 19, 2026
…eption in Connector.__del__ mock
luisremis
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #244
Show the Overall insertion throughput instead of NaN when the error counter is > 0.