Skip to content

test: add initial suite of tests for Images.py#674

Merged
luisremis merged 4 commits into
developfrom
feat/378-tests-for-images-py
May 19, 2026
Merged

test: add initial suite of tests for Images.py#674
luisremis merged 4 commits into
developfrom
feat/378-tests-for-images-py

Conversation

@ad-claw000
Copy link
Copy Markdown
Contributor

Closes #378

This PR adds an initial test suite for Images.py ensuring core functionality is verified. It introduces test/test_Images.py featuring:

  • Tests for math/coordinate utilities (rotate, resolve).
  • Tests for the Images initialization.
  • Tests for Images.search() and Images.search_by_property() using mock API responses.
  • Tests for blob retrieval utilities (get_image_by_index and get_np_image_by_index), which decode images accurately.

Ready for review!

@ad-claw000
Copy link
Copy Markdown
Contributor Author

The tests for Images.py (issue #378) have been successfully run in CI and are passing on all platforms. The PR is ready for review and merge.

@luisremis luisremis requested a review from Copilot May 11, 2026 19:33
luisremis
luisremis previously approved these changes May 11, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an initial pytest-based unit test module for aperturedb.Images utilities and key Images behaviors, using mocked execute_query responses to avoid requiring a live ApertureDB instance.

Changes:

  • Introduces tests for coordinate helpers rotate() and resolve().
  • Adds basic coverage for Images initialization, search(), and search_by_property() query construction + response parsing.
  • Adds tests for blob retrieval/decoding via get_image_by_index() and get_np_image_by_index().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/test_Images.py Outdated
Comment thread test/test_Images.py Outdated
Comment thread test/test_Images.py
Comment thread test/test_Images.py
Copy link
Copy Markdown
Contributor Author

@ad-claw000 ad-claw000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed all Copilot review comments in the latest commit.

@luisremis luisremis merged commit eaa69bf into develop May 19, 2026
3 checks passed
@luisremis luisremis deleted the feat/378-tests-for-images-py branch May 19, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add tests for Images.py

3 participants