fix(loader): fix dry_run execution in dask workers#724
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Propagates the dry_run flag through the Dask execution path so that Dask worker processes don’t accidentally execute ingestion queries when a loader/query is run with dry_run=True.
Changes:
- Pass
dry_runfromParallelQuery.query()intoDaskManager.run(). - Thread
dry_runthrough the Daskmap_partitionsworker function and into the per-workerQueryClassinstance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
aperturedb/ParallelQuery.py |
Passes self.dry_run into the Dask execution path when use_dask is enabled. |
aperturedb/DaskManager.py |
Accepts dry_run, forwards it to Dask workers, and constructs QueryClass with dry_run in each worker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
CI fixes have been implemented and pushed. Let me know if there's anything else! |
- Rename connnector_type to connector_type in DaskManager.py - Use utils.remove_entities in test_dask_dry_run - Fix CSV file path in test_dask_dry_run
luisremis
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagates the
dry_runflag to Dask workers so that when running withdry_run=True, the data is not accidentally ingested by Dask worker instances.Verification
DaskManager.runmethod properly propagatesdry_runwhen instantiatingQueryClass.Fixes #250