Add source tracking for local status#11
Merged
pwrightcertinia merged 9 commits intomainfrom Aug 15, 2023
Merged
Conversation
Closed
bmathewcertinia
commented
Aug 7, 2023
| return res; | ||
| }) | ||
| .catch(() => { | ||
| //TODO: log error |
Contributor
Author
There was a problem hiding this comment.
I've left this in for now as i haven't actually added a logger to this lib yet
Contributor
There was a problem hiding this comment.
To avoid making another logger we can let it throw or use our own error. But it's ok like this for now.
| "typescript": "^4.9.5" | ||
| }, | ||
| "dependencies": { | ||
| "@salesforce/core": "^3.36.1", |
Contributor
There was a problem hiding this comment.
Should be alright, once we upgrade auth helper to latest too
Contributor
Author
|
I've addressed the comments in issue #12 |
pwrightcertinia
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only adds the status for local changes