Change max from parameter to instance variable #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm don't think a check at the top on
maxis necessary to enforce it's consistency, but seeing how blatantly unchanging it was I realized that it would be better as an instance variable than a parameter being carried by the function. If you believe it's necessary to have safety check it that's fine, go ahead and add it, but to me it just seemed like an unnecessary extra operation that gets carried at factorial timescale.I also noticed that in the sort checking portion when
sortedis false and a call is made tothis.bogoIsSorted, if it returned true the falsesortedwould still be returned which means the sort would be rechecked all the way up the function stack. I've changed the return to true to resolve this, as returning there means it is sorted.Thanks for taking a look at this!