Skip to content

Handle empty inputs and show better errors for inputs with varying deepness#7

Merged
percevalw merged 1 commit intomainfrom
empty-and-imbalanced-inputs
Feb 14, 2024
Merged

Handle empty inputs and show better errors for inputs with varying deepness#7
percevalw merged 1 commit intomainfrom
empty-and-imbalanced-inputs

Conversation

@percevalw
Copy link
Copy Markdown
Member

Description

  • Handle empty inputs (e.g. as_folded_tensor([[[], []], [[]]])) by returning an empty tensor
  • Correctly bubble errors when converting inputs with varying deepness (e.g. as_folded_tensor([1, [2, 3]]))

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1f24cd) 100.00% compared to head (6f16b1a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          138       145    +7     
=========================================
+ Hits           138       145    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@percevalw percevalw force-pushed the empty-and-imbalanced-inputs branch from 96d18fc to 6f16b1a Compare February 14, 2024 19:29
@percevalw percevalw merged commit d154ec6 into main Feb 14, 2024
@percevalw percevalw deleted the empty-and-imbalanced-inputs branch February 14, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant