standard_put: false Doesn't work for Embeddables

[ostrolucky]

API Platform version(s) affected: 4.0.14

Description
With standard_put: false, I expect that missing fields would not be reset to NULL. However, this is not true for Embeddables.

How to reproduce

#[ApiResource()]
#[ORM\Entity()
class DatasyncConnector {
    #[ORM\Embedded(Embeddable::class)]
    public ?Embeddable $embeddable = null;
}

#[ORM\Embeddable()]
class MicrosoftGraph
{
    #[ORM\Column(type: 'guid', nullable: true)]
    public string $clientId;
    #[ORM\Column(nullable: true)]
    public ?string $clientSecret = null;
}

If you send payload

{"embeddable": {"client_id": "foo", "client_secret": "bar"}}

And afterwards

{"embeddable": {"client_id": "foo"}}

client_secret would be set to NULL. Expectation is that client_secret would preserve previous value (bar).

Possible Solution

Additional Context
I've not inspected if this is in general problem with any nested objects.

[soyuka]

PUT replaces everything I guess, isn't that working with PATCH though?

[ostrolucky]

PUT with standard_put: true replaces everything. PUT with standard_put: false is designed to replace only fields that are specified in payload. But this doesn't seem working correctly for nested objects/embeddables.

PATCH requires json-patch payload, which is whole different league for our frontend to implement. This is why we do not use it.

[mrossard]

That's an "old" awkward behavior of the non-standard PUT as far as I remember; it's a PATCH-like that completely replaces the contents of the included top-level properties of the resource.

[dunglas]

For the record, our PATCH uses the JSON Merge Patch format, which is very similar to what you can do with the non-standard PUT (that we plan to deprecate at some point).

JSON Patch (which is indeed not very common, even if very practical) is currently not supported by API Platform (but that would be nice to have).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.