ReferenceType needs to be string not Int

[ashmashrest]

The referenceType parameter for getIriFromItem function needs to be a string since the absolute path is a string not an integer. Currently the @id is relative link which should ideally be absolute link.

public function getIriFromItem($item, int $referenceType = UrlGeneratorInterface::ABS_PATH): string

Thanks for a great tool.

[dunglas]

Hi, UrlGeneratorInterface::ABS_PATH is an int: https://github.com/api-platform/core/blob/master/src/Api/UrlGeneratorInterface.php#L40

[ashmashrest]

Hi, Thanks Kévin for correcting me. However currently the @id is relative link which I feel should ideally be absolute link. Let me know your thought?

[dunglas]

What is the benefit of generating an absolute link? It will increase the response size and relative URL are perfectly valid. It's also easier to test and move the API.

[dunglas]

However, it would be nice to make this behavior configurable.

[ashmashrest]

Mostly the API's will be used by third party applications so it will be easier if they get the absolute link to follow rather than the relative link which they need to process. In my scenario, I am trying to leverage your wonderful tool to generate a IIIF compatible manifest http://iiif.io/api/presentation/2.1/ which expects the @id to be an absolute URL.

[ashmashrest]

I agree. Thanks for consideration.

[teohhanhui]

Configurable IRI type (not implemented): #351 #751 api-platform/api-platform#128