Use string values in DateFilter null-management constants

[teohhanhui]

No description provided.

[teohhanhui]

Do we also want to export these class constants as container parameters?

So that instead of writing

    resource.book.date_filter:
        parent: api.doctrine.orm.date_filter
        arguments:
          - datePublished: 0 # Dunglas\ApiBundle\Doctrine\Orm\Filter\DateFilter::EXCLUDE_NULL

I can just write

    resource.book.date_filter:
        parent: api.doctrine.orm.date_filter
        arguments:
          - datePublished: %api.doctrine.orm.date_filter.exclude_null%

[sroze]

IMO it's better to have string values in DateFilter constants.

[ogizanagi]

👍 for string values in DateFilter constants

[teohhanhui]

Are we good?

[sroze]

I'm okay with that. But as there's a BC break, I'm waiting another maintainer's 👍.

[theofidry]

Why not letting the default value settable with ~?

[dunglas]

Ok with Theo.

[teohhanhui]

The null value is for using database default (i.e. no special null handling). That has not been changed.

What I'm doing here is correcting the example for excluding null values (view the full file to see the text above it).

[theofidry]

Makes sense

[dunglas]

👍 it's the good time to break things (before 1.0).
Can you also update the changelog please?

[teohhanhui]

Added a line in changelog

[sroze]

Thank you @teohhanhui ! 👍