Skip to content

Patch/readable names #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MLDMoritz wants to merge 24 commits into from
Closed

Patch/readable names #3221

MLDMoritz wants to merge 24 commits into from

Conversation

@MLDMoritz
Copy link
Contributor

@MLDMoritz MLDMoritz commented Oct 29, 2019

More Descriptive Input/Output class names

Q A
Bug fix? no
New feature? ish
BC breaks? no
Deprecations? no
License MIT

This is an adaption of #2487 for version 2.5

dunglas and others added 23 commits September 23, 2019 14:39
@dunglas
Update branch alias
3366849
@dunglas
Merge branch '2.5'
81d276c
@dunglas
Merge branch '2.5'
59fa1e2
@dunglas
Merge branch '2.5'
9ff7a23
@dunglas
Merge branch '2.5'
9799193
@mRoca
Add entrypoints sorting
854bcc9
@soyuka
Merge pull request #3114 from mRoca/entrypoints-sorting
8e28a58 
Add entrypoints sorting
@dunglas
Merge branch '2.5'
e468d98
@alanpoulain
Possibility to add execute options for MongoDB (#3144)
d8e624b
@toofff
Feat: remove template pull request
4d4ee37
@dunglas
Merge pull request #3137 from toofff/feat-remove-template-pull-request
a4c8af6 
Feat: remove template pull request
@dunglas
Context stamp (#3157)
1931f16 
* Issue #3082: Add and use ContextStamp.

* Issue #3082: Add tests.

* Issue #3157: Correct passing of context.

* Issue #3157: Minor corrections.
@dunglas
Merge branch '2.5'
dfc1771
@bpolaszek @dunglas
Global resource defaults implementation (#3151)
74ee7ef 
* Add defaults configuration

* Suggest defaults in configuration

* Apply changes from code review

* Add deprecation notices for legacy defaults

* Apply @dunglas' suggestions
@teohhanhui
Merge branch '2.5' into merge-2.5
f3312a7
@teohhanhui
Merge pull request #3179 from teohhanhui/merge-2.5
3c371aa 
Merge 2.5 into master
@soyuka
Merge remote-tracking branch 'upstream/2.5' into merge-25
1e7d7ed
@soyuka
Merge pull request #3202 from soyuka/merge-25
480c077 
Merge 25
@BackEndTea
Make the base exception extend throwable
8e21ef2 
This makes it more clear this interface can be 'caught'
@BackEndTea
Use https instead of http
21bbe95
@dunglas
Merge pull request #3219 from BackEndTea/patch-3
59a1702 
Use https instead of http
@dunglas
Merge pull request #3217 from BackEndTea/patch-1
449842a 
Make the base exception extend throwable
@dunglas
Merge branch '2.5'
b125b66 
* 2.5:
  Fix spelling
  Fix removal of illegal characters in schema name for Amazon API Gateway
  Add links to documentation to ApiResource properties
  fix #3189 - JSONAPI pagination ignored when using filter parameter
dunglas
dunglas approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just rebase against master please? As it can break some existing apps (even if it's unlikely), I prefer to not include this in a patch release.

Use human-readable names instead of a hash
b4297d2 
Make tests pass
Make tests pass.
@MLDMoritz
Copy link
Contributor Author

MLDMoritz commented Oct 31, 2019 •
edited
Loading

@dunglas is it correct how I rebased it? Otherwise I would just apply the changes on my master branch and open up a new PR.

If not: #3228 is on master.

@soyuka
Copy link
Member

soyuka commented Nov 1, 2019

superseeded by #3228

@soyuka soyuka closed this Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas dunglas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@MLDMoritz @soyuka @dunglas @mRoca @alanpoulain @toofff @bpolaszek @teohhanhui @BackEndTea