Fix travis test #516
Merged
Fix travis test #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @teohhanhui |
Contributor
|
👍 |
Contributor
|
ping @api-platform/core-team |
Contributor
|
👍 |
Contributor
|
Travis works in mysterious ways 😆 @vincentchalamon I suppose you must have asked yourself that same question when you opened #513 😛 |
Contributor
|
@teohhanhui You're totally right ^^ I didn't understand why my original PR revel this bug… Travis seems strange sometimes, so does Scrutinizer… |
Member
|
It's always the same test, context order isn't stable. What about changing this test to reflect a json schema test instead of hard values? |
Member
|
👍 for @soyuka solution. I this one anyway to make Travis green again. |
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
Fix travis test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified the test with the other commit this one is to fix the tests