Skip to content

Conversation

Simperfit
Copy link
Contributor

@Simperfit Simperfit commented Jul 9, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? will pass
Fixed tickets #539
License MIT
Doc PR todo

This is totally working with hal :

Things todo :

  • Add tests (unit / behat) using halidator
  • refactor if needed ?
  • Drink some coffee
  • Create doc PR

@Simperfit Simperfit changed the title feat: fix #539 hal support [WIP] feat: fix #539 hal support Jul 9, 2016
@Simperfit Simperfit force-pushed the feature/adding-hal-support branch from d952341 to c5163f0 Compare July 9, 2016 15:00
protected function extractAttributes($object, $format = null, array $context = [])
{
return [];
return ['toto'];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@Simperfit Simperfit force-pushed the feature/adding-hal-support branch 2 times, most recently from ab50953 to 04672ab Compare July 11, 2016 13:35
@Simperfit Simperfit force-pushed the feature/adding-hal-support branch from 8e139e1 to 14ca87b Compare July 11, 2016 13:56
@dunglas
Copy link
Member

dunglas commented Jul 11, 2016

For error serialization with HAL, we should support one of those formats: http://phlyrestfully.readthedocs.io/en/latest/problems.html


/**
* Enables JSON-LD and Hydra support.
* Enables JSON-LD, HAL and Hydra support.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change here? hal.xml is not being loaded here...

@dunglas dunglas mentioned this pull request Jul 13, 2016
3 tasks
@Simperfit Simperfit closed this Jul 14, 2016
@Simperfit Simperfit deleted the feature/adding-hal-support branch August 13, 2016 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants