Simperfit feature/adding hal support #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $attributeValue = $this->propertyAccessor->getValue($object, $attribute); | ||
| $type = $propertyMetadata->getType(); | ||
|
|
||
| if ( |
There was a problem hiding this comment.
I feel it looks like a strange indent ?
There was a problem hiding this comment.
Why? What do you suggest?
There was a problem hiding this comment.
if ((is_array($attributeValue) || $attributeValue instanceof \Traversable)
&&
...
dunglas
force-pushed
the
Simperfit-feature/adding-hal-support
branch
from
3bc92e9 to
03bddb3
Compare
|
LGTM with last comments |
dunglas
force-pushed
the
Simperfit-feature/adding-hal-support
branch
from
99db881 to
d3f92a6
Compare
dunglas
force-pushed
the
Simperfit-feature/adding-hal-support
branch
from
d3f92a6 to
67bf830
Compare
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
…ding-hal-support Simperfit feature/adding hal support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #608.