fix(symfony): implement checkContainerIsBooted for bc-layer #7002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/6991
branch
6 times, most recently
from
1cf0ba8 to
02a82c3
Compare
|
|
||
| return $iriConverter->getIriFromResource($resource); | ||
| } | ||
|
|
There was a problem hiding this comment.
- suggestion: Rename the method and the
$kernelOptions['checkContainerIsBooted']toalwaysBootKernelfor better clarity - suggestion: Set
falseas default value, so there is no need to set it inApiTestCaseTest::checkContainerIsBooted - suggestion: Encourage people using Alice to set this value to true by adding a comment on the method
There was a problem hiding this comment.
Using false will certainly break current usages I'll move to false in API Platform 5
There was a problem hiding this comment.
It depends on how we name the method. When using checkContainerIsBooted --> default value is false, if we name it alwaysBootKernel --> default value should be true.
BTW, I proposed #7007 for this bug fix if you want to adapt yours accordingly.
| if (null === ($checkContainerIsBooted = $kernelOptions['checkContainerIsBooted'] ?? static::checkContainerIsBooted())) { | ||
| trigger_deprecation('api-platform', '5.0', \sprintf('In API Platform 5.0 we will not boot the kernel if it is booted already. Define the kernelOptions "checkContainerIsBooted" or implement "%s::checkContainerIsBooted" to return false if you want to keep the old behavior.', static::class)); | ||
| } | ||
|
|
There was a problem hiding this comment.
- question: IMHO, there is no need to check
!static::$bootedif we want to keep exactly the same behaviour as before. - question: Maybe the condition can be simplified to
if ($checkContainerIsBooted)because it's a boolean
There was a problem hiding this comment.
- suggestion:
overrideinstead ofimplements
| { | ||
| if (!static::$booted) { | ||
| if (null === ($checkContainerIsBooted = $kernelOptions['checkContainerIsBooted'] ?? static::checkContainerIsBooted())) { | ||
| trigger_deprecation('api-platform', '5.0', \sprintf('In API Platform 5.0 we will not boot the kernel if it is booted already. Define the kernelOptions "checkContainerIsBooted" or implement "%s::checkContainerIsBooted" to return false if you want to keep the old behavior.', static::class)); |
There was a problem hiding this comment.
typo: Use api-platform/core instead of api-platform in package parameter ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6991