fix(swagger): use current route for footer links #7556
Closed
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
bug fix ? Can you target 4.2 please ? |
Author
|
Yes, this PR fixes a bug where the footer links in Swagger UI were not using the current route, leading to broken links in some setups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using a custom route name for Swagger UI documentation, the footer links (Swagger UI/ReDoc) were pointing to the hardcoded
api_docroute instead of using the actual current route.Changes
src/Symfony/Bundle/Resources/views/SwaggerUi/index.html.twigto useoriginalRouteandoriginalRouteParamsinstead ofapi_docroute